feat(app): add device button action switch - #12305
Open
arhxam wants to merge 1 commit into
Open
Conversation
Failure-Class: none
Collaborator
|
Thanks @arhxam - this is a clean, well-scoped implementation of #4458, and the default-on choice preserves today's behavior for existing users. What I verified:
Two non-blocking notes for the maintainer:
Nice work shipping tests alongside the feature. Product direction decision on the switch scope (global vs per-device) needs maintainer sign-off before merge. by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Add a default-on, persisted master switch for Omi device button actions. Interactive onboarding still receives the button event first, while normal single-, double-, and long-press actions return before side effects when the user disables the switch.
Closes #4458
Product invariants affected
none
How it was verified
flutter test test/unit/device_button_policy_test.dart test/widgets/device_settings_double_tap_test.dart— all 9 preference, policy, persistence, and settings-widget tests passed.flutter gen-l10n— generated all 48 supported locale implementations with zero untranslated messages.bash scripts/analyze_ratchet.sh— analyzer ratchet passed.Tests
Failure-Class: none