fix(web): add the pinned prettier deps to web/app's lockfile - #12288
Merged
undivisible merged 1 commit intoAug 27, 2026
Conversation
64db30c added prettier and prettier-plugin-tailwindcss to web/app/package.json without regenerating web/app/bun.lock, so `bun install --frozen-lockfile` fails on main: error: lockfile had changes, but lockfile is frozen note: try re-running without --frozen-lockfile and commit the updated lockfile web/app/test.sh installs with a frozen lockfile, so the web-app-checks manifest entry fails for every PR that touches web/app/src/** -- it surfaced on BasedHardware#12262, whose only web change is a regenerated omiApi.generated.ts client. Other open PRs are green because none of them trip the trigger paths. Reproduces on a pristine checkout of main with no branch involved: mkdir -p /tmp/mainweb git archive origin/main web/app | tar -x -C /tmp/mainweb cd /tmp/mainweb/web/app && bun install --frozen-lockfile web/admin took the same package.json edit in that commit but its lockfile already resolves, so this is scoped to web/app. Regenerated with a plain `bun install`. The diff is the two declared deps and their resolution entries, six lines, no transitive drift: + "prettier": "^2.8.8", + "prettier-plugin-tailwindcss": "^0.3.0", + "prettier": ["prettier@2.8.8", ...] + "prettier-plugin-tailwindcss": ["prettier-plugin-tailwindcss@0.3.0", ...] Verified: `bun install --frozen-lockfile` succeeds against a cleared node_modules, and `bash web/app/test.sh` passes 66 files / 394 tests. Failure-Class: none
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 27, 2026
Open
Closed
Collaborator
|
ty bro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
64db30c791("fix(web): pin prettier and tighten pre-commit toolchain resolution") added two dev deps toweb/app/package.jsonwithout regeneratingweb/app/bun.lock:web/app/test.shinstalls with a frozen lockfile, so it fails:That is the
web-app-checksmanifest entry, which triggers onweb/app/src/**,web/app/package.json,web/app/bun.lock, and friends. So every PR touchingweb/app/src/**inherits a redHygieneandBuild, regardless of what it changed.It surfaced on #12262, whose only web-side change is a regenerated
omiApi.generated.tsclient. Other open PRs are green purely because none of them happen to trip the trigger paths — this is latent, not rare.Reproduction
Pristine checkout of
main, no branch involved:Reproduces on
ed5a6fc42c.web/admin/package.jsontook an edit in the same commit, but its lockfile already resolves — I checked it separately (790 packages installed, no error), so this is scoped toweb/appalone.The fix
A plain
bun install, committing the result. The diff is the two declared deps and their resolution entries — six lines, no transitive drift:Verification
bun install --frozen-lockfileagainst a clearednode_modules— succeeds (was the failure above).bash web/app/test.sh— 66 files, 394 tests, 0 failures.localStorage.Failure-Class: none