docs(desktop-windows): update AGENTS.md with Node 22 pin, Wayland notes, and parity audit - #12256
docs(desktop-windows): update AGENTS.md with Node 22 pin, Wayland notes, and parity audit#12256formed2forge wants to merge 1 commit into
Conversation
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for this — the re-audit work is thorough and the Node-pin writeup is exactly the kind of environment gotcha worth having in the guide. I verified the new paragraph's claims against package.json (engines.node >=22.19.0 <23), desktop/windows/.nvmrc (22.19.0), desktop-windows-ci.yml (actions/setup-node@v7, node-version: 22, pnpm/action-setup@v6 pinned to 10), and scripts/check-node-version.mjs (the pretest hook) — all accurate.
Two things need fixing before this can merge:
-
Please rebase onto current
main. Your branch is 279 commits behind (merge-base 2026-08-21). Essentially all of this PR — thedesktop/windows/AGENTS.mdfile itself, the rootAGENTS.mdindex row, the lean-check budget entry,.nvmrc, and the full 2026-08-22 parity re-audit including14-sequencing-plan.md— already landed on main via your own #12034 (merged 2026-08-24). I compared all 21 changed files against main: 20 are byte-identical. After a rebase this PR will contain only the genuinely new content. -
The Node-pin paragraph pushes the guide over its size budget.
desktop/windows/AGENTS.mdwould be 136 lines / 7,414 bytes against the ratchet budget of 127 lines / 6,950 bytes in.github/scripts/check_agents_md_lean.py(theagents-md-leancheck, run in both the local and ci lanes via.github/checks-manifest.yaml). No Actions run happened on this head, so nothing surfaced it — but it will failrepo-checkson merge to main. The check's own guidance is to move detail down a level rather than grow the file: the Node 24localStorage/jsdom failure story and--localstorage-filedetail would fit naturally indocs/multi-worktree-dev.md(which already carries the env quirks table) or adocs/agents/note, linked from the guide in one line. Alternatively, condense the paragraph to its core instruction (pin Node 22 via.nvmrc/nvm use; thepretesthook catches mismatches early) — that fits within the current budget.
The paragraph's substance is right; it's purely a placement/size issue per the repo's lean-guide policy. With a rebase plus either the trim or the move, this should be a quick re-review.
by AI on behalf of David — if you need David’s attention urgently, please @Git-on-my-level and escalate with need human response.
package.json's engines field and .nvmrc already constrain Node to >=22.19.0 <23, and scripts/check-node-version.mjs fires at pretest to produce a legible error message, but nothing in the AGENTS.md told a contributor before they hit the check or, worse, saw silent jsdom localStorage breakage on Node 24+. Add a one-line note mirroring the existing pnpm major-version pin entry. .nvmrc (22.19.0) was already merged via BasedHardware#12034. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
91d84b7 to
2faa66f
Compare
|
Rebased onto current upstream/main (was 408 commits behind). Key findings after comparing all 8 original commits against upstream: Already merged via #12034:
Still genuinely missing (applied in this rebase):
Branch is now 1 commit ahead of upstream/main, agents-md-lean check passes (127 lines, 6,944 bytes). CI should be clean. |
|
@Git-on-my-level both items from your review are resolved — requesting a re-look:
All 12 CI checks pass. Happy to adjust wording if anything looks off. |
Both concerns from this review are resolved on the current head (2faa66f): the branch was rebased onto main (PR is now main + 1 commit), and the Node-pin paragraph was condensed to a single line, bringing desktop/windows/AGENTS.md to 127 lines / 6,944 bytes — inside the (127, 6,950) ratchet in .github/scripts/check_agents_md_lean.py.
Git-on-my-level
left a comment
There was a problem hiding this comment.
Thanks for the clean rebase — both items from my earlier review are resolved on this head, and I verified each independently:
- Rebase: the branch is now
main+ 1 commit, and the net diff is exactly one added line indesktop/windows/AGENTS.md(the Node-pin note, placed right after the pnpm major-version pin paragraph). - Size budget: the file measures 127 lines / 6,944 bytes against the 127-line / 6,950-byte ratchet in
.github/scripts/check_agents_md_lean.py— inside budget, and the condensation kept the actionable core (.nvmrc+nvm use,pretestguard).
I also re-checked every claim in the new line against the tree:
engines.nodeis>=22.19.0 <23indesktop/windows/package.json✓desktop/windows/.nvmrcis22.19.0✓pretestrunsnode scripts/check-node-version.mjs, and the script exists ✓ — its header documents the same Node ≥ 24 failure mode the note cites (Node's own experimentallocalStorageglobal shadows jsdom's), so the "Node 24+ breaks vitest" claim is corroborated by the guard itself ✓
One maintainer-facing note: this edits an agent instruction file. The new line will steer AI coding/review agents working in desktop/windows/ to select Node 22 before running the suite. I checked the guidance against package.json, .nvmrc, and the pretest guard — it's accurate, consistent with the adjacent pnpm-pin paragraph, and asks nothing of agents beyond version selection, so I consider it safe.
I've dismissed my earlier changes-requested review (both concerns resolved) and removed the docs-accuracy label. Checks are green on this head.
by AI on behalf of David — leaving formal approval to a human maintainer since this is an agent-guidance edit.
Summary
Comprehensive update to the Windows/Linux desktop
AGENTS.mddocumentation:AGENTS.mdand adds.nvmrcTest plan
.nvmrcpins to Node 22🤖 Generated with Claude Code