Fix floating title bar separator appearing when disabled#337
Open
kbkozlev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where a visible separator line appeared between the title bar and main window even when the floating title bar feature was disabled. The separator was particularly noticeable at higher scaling levels (120%, 145%).
Root Cause
The separator was being drawn unconditionally in the paintTitleBar() function before checking whether the floating title bar was enabled. This caused it to render in both floating and non-floating title bar modes.
Changes
Moved the separator drawing code inside the if (m_internalSettings->floatingTitlebar()) conditional block
The separator now only renders when the floating title bar is actually enabled
The traditional (non-floating) title bar path no longer draws this separator
File Changed
darklydecoration.cpp - Decoration::paintTitleBar() function
Testing
The separator no longer appears when floating title bar is disabled
No visual changes when floating title bar is enabled
Should resolve the issue across all scaling levels
Closes
Fixes #320