Repository navigation
fix: register logical models in Pi children - #111
Closed
BakerSean168 wants to merge 1 commit into
Closed
BakerSean168 wants to merge 1 commit into
BakerSean168 wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded by #112. Review after #112 showed this child-only split would make native child behavior mode-dependent: foreground children would load only the five virtual-model definitions, while detached/background children still ambient-load the full ForgeFlow extension and then load this separate required extension. Pi permits duplicate virtual-model registration by replacement, so this is not a crash, but it does not actually establish a consistent child boundary. #112 instead requires the same ForgeFlow extension path that background discovery already uses, keeping foreground/background behavior aligned while preserving nested/recovery propagation. No unique change from this PR remains necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forgeflow/reviewerand the other logical roles resolve in foreground children underpi-subagents@0.75.0Why
pi-subagents@0.75.0contains the upstream virtual-child registration and verification fixes, but foreground children intentionally do not load the parent's ambient extensions. The parent could listforgeflow/reviewer, while the reviewer child still failed withModel forgeflow/reviewer:high not foundbecause ForgeFlow's virtual-model registration extension was absent inside that child.Verification
npm run check: 48/48 passednpm pack --dry-run: includesextension/child-model-policy.jsgit diff --check: passedforgeflow/plannerlaunched builtin reviewer on configured logical role; reviewer read the probe and completed successfully; parent returned exactPARENT_PASSmodel_verification_failedor logical-model-not-found runtime error