Repository navigation
feat: add Pi virtual model policy - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi-subagents@0.74.0reviewer-child selection until its already-merged virtual-child fixes ship in a releaseArchitecture
task/role -> ForgeFlow logical model -> Pi virtual-model dispatch -> physical model -> provider/channelForgeFlow does not own credentials, endpoint selection, channel weights, quota routing, provider retries, or transport.
Upstream compatibility
pi-subagents@0.74.0was released before upstream #2636 (07946874, child virtual-model registration) and #2638 (1fe508f1, virtual selection verification). Those fixes are merged on upstream main but not yet in an npm release. Raw Git dependencies are not viable because the upstream repo publishes TypeScript source and Node refuses type stripping insidenode_modules. This PR therefore does not forceforgeflow/reviewerinto child workflows yet; it avoids a local compatibility shim and keeps current review behavior working.Verification
npm run check— 46/46 tests passednpm pack --dry-run— passedgit diff --check— passedpi --no-extensions -e ./extension/index.js --approve --list-models forgeflowlists planner/worker/reviewer/scout/oracleFollow-up
When a released
pi-subagentscontains upstream #2636/#2638, upgrade the dependency, add a real virtual-child integration canary, and hard-cut review/accept child launches toforgeflow/reviewer. Provider configuration remains separate; LiteLLM stays the baseline while New API/Bifrost can be evaluated behind the provider boundary.