fix(filters): reject invalid coordinates; report rejections and the threshold profile - #1
Merged
Merged
Conversation
NaN, infinite and out-of-range latitude/longitude are dropped before the null-island and statistical tests. Add filter_points_with_report, which counts rejections per class and reports an explicit outcome.
Name the existing ground-vehicle defaults as GROUND_VEHICLE_PROFILE, make them the single source of the keyword defaults, and have FilterReport.profile state the thresholds a run applied (custom when any differ). No new activity profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPX-1 and GPX-2 from the portfolio remediation plan.
filter_points_with_reportandFilterReport: per-class rejected counts (all seven keys, in application order), an explicit outcome (ok,empty_input,all_rejected), and the effective threshold profile.GROUND_VEHICLE_PROFILEand make them the single source of the keyword defaults; a test asserts they cannot drift. A run with any changed threshold reports acustomprofile, which means "your numbers", not "validated for an activity". No new activity profiles.filter_high_quality_pointskeeps its signature and return type and delegates to the report form. README and CHANGELOG updated.Test plan
filter_points_with_report,GROUND_VEHICLE_PROFILEmissing).Optional[]hits follow the file's existing styleAcceptance
all_rejected, distinct fromempty_input; exact (0,0) is still dropped and counted asnull_island; one-axis zeros survive.FilterReport.profileis set on every outcome, including empty and all-rejected; any non-default threshold reportscustom; docs state only the ground-vehicle profile exists.