fix(sparql): scope contributor data per document to prevent cross-gra…#191
Open
torbjokv wants to merge 1 commit into
Open
fix(sparql): scope contributor data per document to prevent cross-gra…#191torbjokv wants to merge 1 commit into
torbjokv wants to merge 1 commit into
Conversation
…ph merging
In Neptune, contributor triples from different publications/NVI candidates sharing the same person URI (e.g. cristin/person/14967) merge across
named graphs. This causes queries to return affiliations from all publications instead of just the relevant one.
- CONSTRUCT views: Replace person URI subjects with per-document scoped nodes that preserve the person URI via :identity
- Publications: use the existing ?contributor blank node from the WHERE sub-select
- NVI candidates: use a Skolem IRI derived from the candidate URI + contributor URI (blank nodes can't be reused across solution rows in SPARQL
CONSTRUCT due to the Cartesian product with approval data)
- SELECT templates (contributor, affiliation, nvi, nvi-institution-status): navigate through ?contributor :identity ?contributorUri to extract
the person identifier
- Test data (.nt files): updated to match the new CONSTRUCT output structure
Test Results 15 files 15 suites 53s ⏱️ Results for commit 6b7bb34. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ph merging
In Neptune, contributor triples from different publications/NVI candidates sharing the same person URI (e.g. cristin/person/14967) merge across
named graphs. This causes queries to return affiliations from all publications instead of just the relevant one.