Skip to content

286 add dataset attachment to objects instead of collections when parsing#299

Merged
LucasZimm merged 13 commits into
mainfrom
286-add-dataset-attachment-to-objects-instead-of-collections-when-parsing
Jun 1, 2026
Merged

286 add dataset attachment to objects instead of collections when parsing#299
LucasZimm merged 13 commits into
mainfrom
286-add-dataset-attachment-to-objects-instead-of-collections-when-parsing

Conversation

@LucasZimm

Copy link
Copy Markdown
Collaborator

Entities:

  • adds the datasets property for ObjectType
  • can use object.add_dataset to add a filepath

Parser:

  • added feature to parse datasets attached to objects

Later Todo:

  • dataset saving is not yet transaction compatible

Fixed:

  • Fixed Loop for Object property generation (could only do one property)

@LucasZimm LucasZimm requested a review from JosePizarro3 May 26, 2026 12:24
@LucasZimm LucasZimm self-assigned this May 26, 2026
@LucasZimm LucasZimm added feature New features added to the API enhancement Enhancements on the code base labels May 26, 2026
@LucasZimm LucasZimm linked an issue May 26, 2026 that may be closed by this pull request
@LucasZimm LucasZimm added fix Bug fixes and removed enhancement Enhancements on the code base labels May 26, 2026
@JosePizarro3 JosePizarro3 added enhancement Enhancements on the code base and removed fix Bug fixes labels May 27, 2026
@coveralls

coveralls commented May 27, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26742887856

Coverage remained the same at 0.0%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 0
Covered Lines: 0
Line Coverage: NaN%
Coverage Strength: 0.0 hits per line

💛 - Coveralls

@JosePizarro3 JosePizarro3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

Comment thread bam_masterdata/metadata/entities.py Outdated
Comment thread bam_masterdata/cli/run_parser.py Outdated
@LucasZimm LucasZimm merged commit 39c0c77 into main Jun 1, 2026
6 checks passed
@LucasZimm LucasZimm deleted the 286-add-dataset-attachment-to-objects-instead-of-collections-when-parsing branch June 1, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements on the code base feature New features added to the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dataset attachment to objects instead of collections when parsing

3 participants