Forward OpenTelemetry tags enricher onto the inner FIC client-assertion leg (AB#3696484) - #3968
Merged
Merged
Conversation
neha-bhargava
force-pushed
the
nebharg/fic-otel-enricher
branch
from
July 24, 2026 16:35
72c753d to
dd57193
Compare
…sertion leg Fixes the FIC OTel enrichment gap (AB#3696484): an enricher configured on the outer app-token request (via WithOtelTagsEnricher) was not applied to the inner FIC client-assertion token request, so that leg's metrics lacked the enrichment tags. OidcIdpSignedAssertionProvider now forwards the enricher (surfaced by MSAL on AssertionRequestOptions.OtelTagsEnricher) onto the inner AcquireTokenOptions via an ExtraParameters SDK-to-SDK channel that TokenAcquisition reads to call WithOtelTagsEnricher on the inner acquisition. Depends on the MSAL change that surfaces the enricher on AssertionRequestOptions (blocked draft until that MSAL version releases). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d296b5aa-33db-4934-a697-cdf1c1999e09
…requests Extend the FIC OTel enricher wiring to both managed identity acquisition sites so their metrics (including proactive background refresh) carry the same enrichment tags: - TokenAcquisition MI path: honor the ExtraParameters[OtelTagsEnricherKey] SDK-to-SDK channel. - ManagedIdentityClientAssertion (MI-as-FIC leg): forward assertionRequestOptions.OtelTagsEnricher, mirroring the OIDC IdP assertion leg. Depends on MSAL exposing WithOtelTagsEnricher for AbstractManagedIdentityAcquireTokenParameterBuilder<T>. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d296b5aa-33db-4934-a697-cdf1c1999e09
neha-bhargava
force-pushed
the
nebharg/fic-otel-enricher
branch
from
July 24, 2026 23:12
dd57193 to
e6c3cd2
Compare
neha-bhargava
marked this pull request as ready for review
July 25, 2026 00:08
bgavrilMS
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forwards the outer app-token request's MSAL OpenTelemetry tags enricher onto the inner FIC client-assertion leg, so that leg's metrics carry the same enrichment tags as the outer acquisition.
Why
SEAL telemetry bug AB#3696484: the inner FIC credential-exchange metrics were missing the enrichment tags applied to the outer request.
How
OidcIdpSignedAssertionProviderreadsAssertionRequestOptions.OtelTagsEnricher(surfaced by MSAL) and forwards it onto the innerAcquireTokenOptions.ExtraParameters[Constants.OtelTagsEnricherKey].TokenAcquisition(app-token path) reads that key and applies it viabuilder.WithOtelTagsEnricher(...).Blocked on (draft)
Depends on the MSAL change that surfaces
AssertionRequestOptions.OtelTagsEnricher. CI will not build until the MSAL pin is bumped to the release containing it. Kept as a draft until then.Related