Repository navigation
parser: collect intermediates into interBuffer, not paramBuffer - #57
Open
dushankw (dkw-oss) wants to merge 1 commit into
Open
dushankw (dkw-oss) wants to merge 1 commit into
dushankw (dkw-oss) wants to merge 1 commit into
Conversation
collectInter appends the current intermediate byte to interBuffer but
assigns the result to paramBuffer. Consequences:
- interBuffer stays permanently empty, so no intermediate ever reaches
escDispatch: a charset designation such as ESC ( B arrives with no way
to tell "(" from ")" (or from no intermediate at all), which blocks
implementing those sequences or any other intermediate-carrying one.
- The intermediate byte lands in the parameter buffer instead. None of
the currently handled finals take intermediates, so nothing visibly
breaks today, but the state is wrong and becomes load-bearing the
moment a handler consults either buffer.
Assign to interBuffer, matching collectParam one function above. Tests
cover the escape-side call sites: the Escape -> EscapeIntermediate
transition and accumulation within EscapeIntermediate.
Contributor
|
dushankw (@dkw-oss) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collectInter appends the current intermediate byte to interBuffer but assigns the result to paramBuffer. Consequences:
Assign to interBuffer, matching collectParam one function above. Tests cover the escape-side call sites: the Escape -> EscapeIntermediate transition and accumulation within EscapeIntermediate.