Skip to content

chore(deps): golang.org/x/sys v0.1.0 - #47

Merged
Brian Goff (cpuguy83) merged 2 commits into
Azure:masterfrom
thaJeztah:sys_tagged
Oct 6, 2026
Merged

Brian Goff (cpuguy83) merged 2 commits into
Azure:masterfrom
thaJeztah:sys_tagged

Conversation

@thaJeztah

Copy link
Copy Markdown
Contributor

use a tagged version for golang.org/x/sys; note that versions before v0.44.0 have a CVE (https://pkg.go.dev/vuln/GO-2026-5024 / CVE-2026-39824), but this doesn't impact this module;

GOOS=windows govulncheck ./...
=== Symbol Results ===

No vulnerabilities found.

Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 0
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

full diff: golang/sys@33da011...v0.1.0

@thaJeztah

Copy link
Copy Markdown
Contributor Author

Brian Goff (@cpuguy83) PTAL

Also opened #48 if you prefer fixing the false positive.

@thaJeztah

Copy link
Copy Markdown
Contributor Author

🤔

Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.1.0\windows\syscall.go:84:16: undefined: unsafe.Slice
Error: C:\Users\runneradmin\go\pkg\mod\golang.org\x\sys@v0.1.0\windows\syscall_windows.go:141:29: undefined: unsafe.Slice

@thaJeztah

Copy link
Copy Markdown
Contributor Author

Ah, probably go is just way too old;

go 1.16

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
use a tagged version for golang.org/x/sys; note that versions before v0.44.0
have a CVE (https://pkg.go.dev/vuln/GO-2026-5024 / CVE-2026-39824), but this
doesn't impact this module;

```
GOOS=windows govulncheck ./...
=== Symbol Results ===

No vulnerabilities found.

Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 0
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
```

full diff: golang/sys@33da011...v0.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Contributor Author

updated to go1.17 as minimum, to match https://github.com/golang/sys/blob/v0.1.0/go.mod#L3C1-L3C8

@thaJeztah

Copy link
Copy Markdown
Contributor Author

thx for kicking CI; looks happy now 👍

@cpuguy83
Brian Goff (cpuguy83) merged commit 8c912ac into Azure:master Oct 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants