Allow roleDefinitions in resource ID lint rule#19888
Conversation
|
@microsoft-github-policy-service agree |
|
CLA agreement posted above; confirming here that I agree as an individual contributor. |
anthony-c-martin
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
|
The PR compliance job is failing because no docs label is applied: |
|
@nkgotcode there are some test failures - I suspect you probably just need to update baselines. See https://github.com/Azure/bicep/blob/main/CONTRIBUTING.md#updating-test-baselines |
Head branch was pushed to by a user without write access
|
Pushed 2687fa6 to update |
Description
Fixes #19445.
Allows the
use-resource-id-functionslinter rule to recognizeroleDefinitions(...).idas an allowedroleDefinitionIdvalue. This avoids a false positive for the built-inroleDefinitionshelper while preserving the existing resource ID validation for other expressions.Validation:
PATH="$PWD/../.dotnet:$PATH" DOTNET_ROOT="$PWD/../.dotnet" DOTNET_CLI_TELEMETRY_OPTOUT=1 dotnet build src/Bicep.Core.UnitTests/Bicep.Core.UnitTests.csproj --no-restorePATH="$PWD/../.dotnet:$PATH" DOTNET_ROOT="$PWD/../.dotnet" DOTNET_CLI_TELEMETRY_OPTOUT=1 dotnet run --project src/Bicep.Cli -- lint repro-oss-1557/main.bicepChecklist
Microsoft Reviewers: Open in CodeFlow