Make generateParams e2e cleanup best-effort to fix Windows EPERM flake#19788
Draft
Copilot wants to merge 2 commits into
Draft
Make generateParams e2e cleanup best-effort to fix Windows EPERM flake#19788Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Debug test failures in local bicep branch
Make generateParams e2e cleanup best-effort to fix Windows EPERM flake
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows VSCode extension e2e job in #19786 failed with
Tests: 38 passed, 39 total— thegenerateParamstest body passed but itsfinallycleanup hitEPERMonrmSyncbecause VS Code's file watcher still heldmain.parameters.json. Baselines in #19786 were regenerated correctly; this failure is unrelated to that PR.Changes
src/vscode-bicep/src/test/e2e/generateParams.test.ts: replacermSync(tempFolder, { recursive: true, force: true })with the same best-effort pattern already used bydecompile.test.ts,emptyConfigFileSnippets.test.ts, andcreateBicepConfig.test.ts—maxRetries: 5,retryDelay: 1000, wrapped intry/catchso transient Windows file-handle races during cleanup don't fail an otherwise-passing test.Relevant log excerpt:
Original prompt
Created from VS Code.