Fix local deploy compilation for large module templates#19754
Open
GABRIELNGBTUC wants to merge 2 commits into
Open
Fix local deploy compilation for large module templates#19754GABRIELNGBTUC wants to merge 2 commits into
GABRIELNGBTUC wants to merge 2 commits into
Conversation
When `targetScope = 'local'`, module `properties.template` was emitted via `EmitProperty(string, string)`, which serialized it as an ARM expression string literal and hit the 131072-character literal limit for large modules. This change emits the nested module template as a plain JSON string value in `TemplateWriter.EmitModuleForLocalDeploy`, avoiding expression literal serialization and preventing the internal `ExpressionException`. Also adds regression test `Test_Issue19750` in `ScenarioTests` to verify large local module templates compile successfully and are emitted as valid JSON string content.
Co-authored-by: Anthony Martin <38542602+anthony-c-martin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19750
Description
Removes the 132k characters limit for compiled modules in local deploys by using the JSON writer instead of the text writer.
Tested against a production bicep file blocked by this issue and no side effects have been noticed.
Checklist