[Storage] APIView TypeSpec Changes (pre-emitter support)#42896
Open
vincenttran-msft wants to merge 5 commits intomainfrom
Open
[Storage] APIView TypeSpec Changes (pre-emitter support)#42896vincenttran-msft wants to merge 5 commits intomainfrom
vincenttran-msft wants to merge 5 commits intomainfrom
Conversation
microsoft-github-policy-service
Bot
added
the
Storage
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
| /** The result of a Filter Blobs API call */ | ||
| @Xml.name("EnumerationResults") | ||
| model FilterBlobSegment { | ||
| model FilterBlobResponse { |
Member
There was a problem hiding this comment.
Have these new names been run by architects? I believe they usually prefer Result as a suffix over Response
|
|
||
| alias StructuredContentLengthParameter = { | ||
| /** Required if the request body is a structured message. Specifies the length of the blob/file content inside the message body. Will always be smaller than Content-Length. */ | ||
| @access(Access.internal) |
Member
There was a problem hiding this comment.
Should this be scoped down to just rust? FYI @jeremymeng @jorgerangel-msft @l0lawrence @gracewilcox
Member
There was a problem hiding this comment.
per offline discussion, seems this isnt an issue for the other langs, Go is pending but we can update as needed in a follow up pr
catalinaperalta
approved these changes
May 5, 2026
Member
|
@vincenttran-msft to unblock merging into main, typespec validation needs to be passing |
github-actions
Bot
added
data-plane
BreakingChangeReviewRequired
catalinaperalta
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.