Expose backup storage redundancy for SQL MI LTR backups - #30110
Open
svmicano wants to merge 1 commit into
Open
Conversation
Contributor
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
svmicano
force-pushed
the
svmicano/expose-mi-ltr-backup-redundancy
branch
from
September 4, 2026 11:04
fd9a3c6 to
b3c0b3b
Compare
Member
|
/azp run |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent with existing patterns, include a targeted unit test, and appear to correctly surface and map the already-returned SDK property.
Pull request overview
This PR exposes the backupStorageRedundancy value returned by the SQL REST API/.NET SDK on the PowerShell output model for Managed Instance LTR backups, so users can see the backup storage redundancy in Get-AzSqlInstanceDatabaseLongTermRetentionBackup results.
Changes:
- Added
BackupStorageRedundancyto the Managed Instance LTR backup PowerShell output model. - Mapped
ManagedInstanceLongTermRetentionBackup.BackupStorageRedundancyinto the PowerShell model in the adapter. - Added a unit test validating the SDK-to-PS model mapping and updated the Sql module changelog.
File summaries
| File | Description |
|---|---|
| src/Sql/Sql/ManagedDatabase Backup/Services/AzureSqlManagedDatabaseBackupAdapter.cs | Maps the SDK BackupStorageRedundancy field into the PowerShell output model (and makes mapping callable from unit tests). |
| src/Sql/Sql/ManagedDatabase Backup/Model/AzureSqlManagedDatabaseLongTermRetentionBackupModel.cs | Adds BackupStorageRedundancy to the output model surfaced to users. |
| src/Sql/Sql/ChangeLog.md | Documents the user-visible output change under “Upcoming Release”. |
| src/Sql/Sql.Test/UnitTests/AzureSqlManagedDatabaseBackupAdapterTests.cs | Adds unit coverage to ensure BackupStorageRedundancy is mapped correctly (and validates RG parsing from resource ID). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
Contributor
|
Commenter does not have sufficient privileges for PR 30110 in repo Azure/azure-powershell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Description
Expose the backup storage redundancy type returned by
Get-AzSqlInstanceDatabaseLongTermRetentionBackup.The SQL REST API and generated .NET SDK already return
backupStorageRedundancy, but the hand-written Managed Instance LTR PowerShell output model did not define the property and the adapter did not map it. This change adds the output property and maps the existing SDK value.Related work item: https://msdata.visualstudio.com/Database%20Systems/_workitems/edit/5161960/
Validation performed:
backupStorageRedundancywith valueGeo.git diff --checkpassed.Not run: module build or unit test execution, per the author's request to approve builds first.
Mandatory Checklist
Please choose the target release of Azure PowerShell.
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriately