feat(kvp): add diagnostics layer over KvpPoolStore#313
Open
peytonr18 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 95.70% 95.92% +0.22%
==========================================
Files 23 24 +1
Lines 7705 8127 +422
==========================================
+ Hits 7374 7796 +422
Misses 331 331 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
DiagnosticsKvplayer that centralizes azure-init's KVP telemetry behavior, including event key formatting, message chunking, and message reassembly. This provides a single tested implementation that can be reused by the follow-up wiring PR and simplifies the existing logic inkvp.rsandlogging.rs.It also adds
diagCLI commands for decoding and viewing KVP telemetry as readable events, making provisioning diagnostics easier to inspect and troubleshoot.Specifically, this PR adds:
DiagnosticsKvp, a typed view overKvpPoolStorethat implements telemetry-specific behavior while keeping the underlying store format-agnostic:<prefix>|<vm_id>|<level>|<name>|<event_id>.append_multipleand reassembled when read.PROVISIONING_REPORT, or malformed event keys.New
diagCLI commands (dump,events,tail,clear) that operate on decoded and reassembled telemetry data, separate from the existing raw KVP commands.Example
A long event is stored as multiple records sharing one key. The raw view shows the fragments;
diagdecodes and reassembles them into a single event: