Fix specialization double-start race - #841
Open
Swapnil Nagar (swapnil-nagar) wants to merge 1 commit into
Open
Conversation
Preserve initialized app state when worker init and environment reload target the same directory, and exclude node_modules from entry-point globs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eff15798-612c-4121-a6d4-ec5e093bff1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A specialization race can send
WorkerInitRequestandFunctionEnvironmentReloadRequestfor the same real app. Resetting app state before the second startup loses v4 registrations, while Node's module cache prevents their side effects from running again, leaving the worker on the default v3 model with no loadable functions.This change preserves the initialized
AppContextwhen both requests target the same directory while still applying the specialized environment and working directory. Normal placeholder specialization continues to reset and start the real app when its directory differs. Entry-point globbing also excludesnode_modulesso broadmainpatterns cannot load dependencies as application entry points.Tests cover v4 model and function-registration preservation across the duplicate lifecycle sequence, normal placeholder specialization, and
node_modulesglob exclusion.Fixes #838