ci(cspell-misc): declare contents: read#8163
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The sibling cspell-ext.yml already uses permissions: contents: read. cspell-misc only checks out and runs cspell - same scope is correct. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
requested review from
danieljurek,
jongio,
rajeshkamal5050,
tg-msft,
vhvb1989 and
wbreza
as code owners
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the cspell-misc GitHub Actions workflow with the existing cspell-ext workflow by explicitly declaring minimal GITHUB_TOKEN permissions (contents: read). This supports the repo’s least-privilege CI posture while keeping behavior unchanged for a workflow that only checks out code and runs cspell lint.
Changes:
- Add top-level
permissions: contents: readto.github/workflows/cspell-misc.ymlto match.github/workflows/cspell-ext.yml. - No change to job steps or triggers; only the workflow token scope is constrained.
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
dca3894 to
a869c6f
Compare
Author
|
Hi @hemarina, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to align cspell-misc.yml with its sibling cspell-ext.yml, which already declares
permissions: contents: readat the top level. The workflow only checks out the tree and runscspell lint- no GitHub API surface - so the same scope fits.Confirmed with
yaml.safe_loadparse. No behavior change.