This repository was archived by the owner on May 22, 2026. It is now read-only.
Refactor: extract shared regeneration logic into regenerate-common.ts - #3340
Merged
Conversation
Extract shared constants, interfaces, and utility functions from regenerate.ts into a new regenerate-common.ts module to enable code reuse across repos. Extracted: - SKIP_SPECS, SpecialFlags, BASE_AZURE_EMITTER_OPTIONS, BASE_EMITTER_OPTIONS - TspCommand, RegenerateFlagsInput, RegenerateFlags, ProcessedEmitterOption, RegenerateConfig interfaces - toPosix, getEmitterOption, getSubdirectories, defaultPackageName, buildOptions, runTaskPool, regenerate utility functions regenerate.ts now imports from regenerate-common.ts and only contains repo-specific configuration and overrides.
Yuchao Yan (msyyc)
requested review from
iscai-msft and
Chenjie Shi (tadelesh)
as code owners
February 13, 2026 04:02
- Add test_model_base_flatten_compatibility.py for flatten model tests - Add test_typetest_union_discriminated.py for discriminated union tests - Fix 'cadl-ranch' -> 'spector' in flatten test comments - Add cspell ignore directives for property test files - Fix import ordering and blank lines in test files
generation-subdir is autorest-only, so guard its assertions with existence checks to avoid failures in shared test runs.
Script syncs regenerate-common.ts, requirements.txt marker sections, and test files from the typespec repo into autorest.python.
ChenxiJiang333
approved these changes
Feb 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for microsoft/typespec#9696