This repository was archived by the owner on May 22, 2026. It is now read-only.
[pipeline] remove delete logic before regeneration - #3141
Merged
Conversation
Yuchao Yan (msyyc)
requested review from
iscai-msft and
Chenjie Shi (tadelesh)
as code owners
July 28, 2025 01:59
| - script: | | ||
| rm -rf test/azure/generated test/unbranded/generated | ||
| npm run regenerate | ||
| - script: npm run regenerate |
Member
Author
There was a problem hiding this comment.
Another solution is that we add --filter for those directory which has patched code. But this solution may need additional maintenance if we plan to add more patch code in the future.
iscai-msft which one do you prefer?
There was a problem hiding this comment.
In Go, we put some keywords like DO NOT EDIT for the generated code. I think Python could follow the similar logic. Only remove the auto-generated code.
Member
There was a problem hiding this comment.
Yeah we could do something like that, let me create an issue for that. For the meantime, this is good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iscai-msft plans to add some patch code in the repo then we should not delete whole repo before regeneration, otherwise there is code diff in CI.