fix: declare click as an explicit runtime dependency#267
Open
Dongbumlee wants to merge 2 commits into
Open
Conversation
The CLI imports click directly for its pager and manual output paths (agentops explain, init explain, doctor explain). click was previously only available transitively via Typer, but Typer 0.26+ no longer depends on click, so a clean 'pip install agentops-accelerator' crashed every explain command with ModuleNotFoundError: No module named 'click'. Add click>=8.1,<9 to project.dependencies so the manual/pager paths work on a fresh install. Verified by building the wheel and installing it into a clean venv: click is pulled automatically and 'agentops explain' and 'agentops doctor explain' exit 0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
set_env_values expects a Path, but location.env_path is Path | None. Return early when env_path is None, fixing the lint (mypy) gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares
clickas an explicit runtime dependency so a cleanpip install agentops-acceleratorno longer crashes on theexplain/ manual commands.Problem
The CLI imports
clickdirectly for its pager and manual output paths (app.py_emit_manual_output/_emit_doctor_explain).clickwas only available transitively via Typer, but Typer 0.26+ no longer depends onclick. As a result, a fresh install of the publishedagentops-accelerator(0.3.11) crashes:\
$ agentops explain
ModuleNotFoundError: No module named 'click'
\\
This affects
agentops explain,agentops init explain, andagentops doctor explain(all formats/flags). It was masked in dev/editable installs and when the[foundry]extra is installed (which pullsclicktransitively), but the base install is broken.Fix
Add
click>=8.1,<9to[project].dependenciesinpyproject.toml.Verification
Found via a full E2E test of the published 0.3.11 package in a fresh venv (44-case command/parameter matrix). Fix verified by building the wheel from this branch and installing it into a brand-new clean venv:
clickis pulled automatically and bothagentops explainandagentops doctor explainexit0.No version bump (setuptools-scm owns versioning). Changelog updated under
[Unreleased] > Fixed.