Fix stale formattedMessage.message when StatusState transitions to Error#371
Merged
srikrishnaveturi merged 1 commit intoJul 8, 2026
Conversation
srikrishnaveturi
force-pushed
the
fix-stale-formatted-message-on-error
branch
from
9c4b0b3 to
83934bd
Compare
ZhidongPeng
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusObj.formattedMessage.message was initialized once as 'Started ProxyAgent Extension Monitoring thread.' and never updated on failure. After 20 consecutive failures the state machine flipped to Error, producing status=Error, code=0, message='Started ProxyAgent Extension Monitoring thread.' -- a misleading startup string visible to CRP/VMSS operators.
Fix: Introduce two atomic helpers set_error / set_success that update status, code, formattedMessage.message, and configurationAppliedTime together. code is set to STATUS_CODE_NOT_OK only when the state machine has reached ERROR_STATUS; it stays STATUS_CODE_OK while Transitioning. Replace all raw update_state() call sites with the helpers.