fix: distinguish completed work from unmerged or declined board items - #1840
Merged
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Azgaar
self-requested a review
September 10, 2026 16:17
barrulus
marked this pull request as ready for review
September 10, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed, unmerged PRs were displayed as Done, alongside completed work. The reconciler now derives terminal Status from GitHub outcomes: completed issues and merged PRs become Done; not-planned/duplicate issues and closed, unmerged PRs become Archive. Open cards left in Done return to Backlog. Other active statuses and actually archived history are preserved; unknown issue closure reasons require review.
Adds issue-closure and PR-closure/reopening triggers. PR events check out only the default branch and execute metadata automation, never PR code. The scheduled sweep repairs missed events and conflicting native project updates. Dry runs now suppress token-failure issue creation as well as field/label writes.
Documents the completion policy and release-time closure review, and updates the PR template to distinguish Fixes from partial references. Done means completed/merged, not necessarily released. Theme/Priority/Size behavior remains fill-only.
Validation: all 47 script tests pass, including runner fixtures for pagination, preview, authentication failure and partial-write failure. Previewing current board data identified exactly three status corrections (#1799, #1819, #1820). Those live cards have been moved to Archive separately; #1690 was closed with implementation evidence, #1721 narrowed to its remaining work, and discussion #1784 resolved. The notes and journey tests used for those acceptance checks also pass (77 tests).
The existing native project workflow settings are UI-only and still need checking for generic closed-to-Done rules; the reconciler provides recovery after such a rule runs. No changes to issue/discussion state are performed by this script.
The shared local commit hook was skipped because its Biome 2.4.15 cannot parse upstream’s 2.5 configuration; none of the changed files is in the Biome source include set. Dedicated script tests and whitespace checks passed.
Hosted CI note: the documentation PR’s lint and unit checks passed. Its Playwright run failed the unchanged legacy added-label note migration check (230 passed, one skipped, one failed). The failure and investigation criteria are tracked in #1841; it is not being treated as a clean browser-suite result. See https://github.com/Azgaar/Fantasy-Map-Generator/actions/runs/34492975245.