Anchor the marker type menu to its button - #1829
Merged
Merged
Conversation
The v1.152.0 stylesheet rewrite dropped the wrapper's position: relative, so the menu positioned against the dialog and opened above the screen.
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Azgaar
self-requested a review
September 10, 2026 10:12
Owner
|
I didn't want to pollute global css space, but we will handle it separately in migration in any case, so good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Markers Overview, the "add marker" type button (❓) appears to do nothing. The menu does open, but it renders above the top of the screen.
The v1.152.0 stylesheet rewrite (#1821) dropped the
#markerTypeSelectorWrapper { position: relative }rule. The menu isposition: absolute; bottom: 100%, so without it the menu positions against the dialog rather than the button. Reproduced on e16db49, the commit before #1827, with the menu's bounding box at y = -212.Fix
Restore the wrapper rule. Asset stamp bumped for
index.css.Verification
Headless Chromium: after a real click on the button the menu is visible with its box inside the dialog, directly above the button.