-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Externalize emblem rendering #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| .claude/worktrees | ||
| /node_modules | ||
| */node_modules | ||
| /public/charges | ||
| /dist | ||
| /coverage | ||
| /playwright-report | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |||||
| "scripts": { | ||||||
| "dev": "vite", | ||||||
| "build": "tsc && vite build", | ||||||
| "postinstall": "symlink-dir ../node_modules/armoria/charges public/charges", | ||||||
| "preview": "vite preview", | ||||||
| "test": "vitest", | ||||||
| "test:e2e": "playwright test", | ||||||
|
|
@@ -45,11 +46,13 @@ | |||||
| }, | ||||||
| "dependencies": { | ||||||
| "alea": "^1.0.1", | ||||||
| "armoria": "file:../armoria/dist", | ||||||
|
||||||
| "armoria": "file:../armoria/dist", | |
| "armoria": "latest", |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
postinstallscript symlinks from../node_modules/armoria/charges, but sincearmoriais installed fromfile:../armoria/dist, its actual location innode_modulesmay differ (it could resolve differently depending on the package manager and file-link handling). Additionally,symlink-diris a dev dependency, meaning thispostinstallscript will fail in production installs (e.g.,npm install --omit=dev). Consider movingsymlink-dirtodependencies, or replacing the postinstall approach with a Vite plugin or build step that copies/links the charges directory.