Custom Upload and Assay Updates (bug fixes) - #16
Closed
sabila-bernard wants to merge 1 commit into
Closed
sabila-bernard wants to merge 1 commit into
sabila-bernard wants to merge 1 commit into
Conversation
test_path() can return a relative path if testthat state is not active when the argument is evaluated (e.g. after AppDriver changes the working directory). Resolve the fixture path to an absolute path at the top of each test, before any AppDriver interaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes five bugs identified during code review of the custom upload and assay selection features:
t()incorrMatUpload()so the compound dropdown shows drug names, not cell barcodesreferenceCompound_uinot evaluating: AddedoutputOptions(output, 'referenceCompound_ui', suspendWhenHidden = FALSE)so the dropdown populates correctly when inside a hiddenconditionalPanelassay_to_use()now guards withreq(rdsSeurat())before callingisOrthogonAL()so navigating the app before uploading a Seurat file doesn't crashdrugSignatures()normalises gene names withtoupper()so lowercase uploads don't produce 0-gene overlap and a silent crashseq_lenfix: Fourfor (i in 1:length(...))loops in the combination analysis replaced withseq_len(nrow(...))to avoid the1:0 = c(1, 0)trap on empty data framesTesting
Added a shinytest2 regression suite (
inst/shiny/tests/testthat/) with tests for all five bugs. CI runs on every PR via.github/workflows/shinytest2.yml. The 134 MB Seurat fixture is tracked via Git LFS; tests that need it skip gracefully when LFS is unavailable.