APIGOV-33097 - buffer the events channel to allow logging receipt of events#1056
Merged
Conversation
jcollins-axway
requested review from
alrosca,
dfeldick,
dgghinea,
sbolosan and
vivekschauhan
as code owners
Collaborator
|
code looks good. Maybe an updated unit test for logEventReceipt |
Collaborator
Author
do we really think that is necessary? I ask because there would be no assertion that could be made with a unit test for that, it would only be for line coverage. Either the function logs something, which we do not assert on, and returns nothing. Or it does not log anything and returns nothing. |
dgghinea
approved these changes
Jul 1, 2026
vivekschauhan
approved these changes
Jul 1, 2026
alrosca
approved these changes
Jul 1, 2026
sbolosan
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.