Skip to content

another attempt to fix concurrent metric collector test#1055

Merged
dgghinea merged 2 commits into
mainfrom
APIGOV-DG002
Jul 9, 2026
Merged

another attempt to fix concurrent metric collector test#1055
dgghinea merged 2 commits into
mainfrom
APIGOV-DG002

Conversation

@dgghinea

Copy link
Copy Markdown
Collaborator

Maybe 70000 goroutines in a single test was a bit too much

@jcollins-axway

Copy link
Copy Markdown
Collaborator

By removing this we are reducing the number of concurrent metrics being given to the SDK, I think by removing this we are invalidating the purpose of the test.

@jcollins-axway jcollins-axway left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not see the benefit of reducing this invalidating the reason for the test

@dgghinea

dgghinea commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

@jcollins-axway it's not exactly removing the test, it's reducing its usage. I think the test is still valid but it's testing 2800 concurrent calls instead of 70000.
I initially thought this was the reason the GitLab runner was failing. but if you think this is not related, I can just close this.

@jcollins-axway

Copy link
Copy Markdown
Collaborator

@dgghinea is it helping anything with the reduction?

@dgghinea

dgghinea commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@dgghinea is it helping anything with the reduction?

I took a look and the time of the test pipeline to finish went from around ~9 mins to 3.5 mins(specifically, the test that was modified went from ~300s to 4s). So I'd say yes

@dgghinea dgghinea merged commit 62f103d into main Jul 9, 2026
2 checks passed
@dgghinea dgghinea deleted the APIGOV-DG002 branch July 9, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants