another attempt to fix concurrent metric collector test#1055
Conversation
|
By removing this we are reducing the number of concurrent metrics being given to the SDK, I think by removing this we are invalidating the purpose of the test. |
jcollins-axway
left a comment
There was a problem hiding this comment.
can not see the benefit of reducing this invalidating the reason for the test
|
@jcollins-axway it's not exactly removing the test, it's reducing its usage. I think the test is still valid but it's testing 2800 concurrent calls instead of 70000. |
|
@dgghinea is it helping anything with the reduction? |
I took a look and the time of the test pipeline to finish went from around ~9 mins to 3.5 mins(specifically, the test that was modified went from ~300s to 4s). So I'd say yes |
Maybe 70000 goroutines in a single test was a bit too much