perf: cache video/playlist metadata, speed up yt-dlp retries - #3
Merged
Conversation
- Add in-memory TTL cache (5 min) keyed by normalized video/playlist id for YouTube video, Twitch video, and playlist metadata lookups; skips repeated yt-dlp spawns on re-pasted/revisited URLs. Only complete results are cached (missing duration or live entries are excluded) to avoid locking in a transient fetch failure. - Remove the artificial 1200ms delay between yt-dlp metadata retries. - Skip the redundant fetch_duration spawn for live videos. - Expand cookies-from-browser fallback to try every detected browser (was: first found only), Firefox first since it doesn't depend on the OS keyring like Chromium-family browsers do. Adds edge/whale on Linux and chromium/opera/whale on Windows to the detection list. - Add parking_lot dependency for the cache mutex, per project convention (LazyLock + parking_lot over OnceLock/std Mutex).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a playlist/metadata cache and speeds up yt-dlp retries. Rebased onto main after the audio-quality-selector merge; cookie-retry logic in youtube.rs was hand-merged to combine both branches' improvements (upfront cached-cookie fast path + full multi-browser retry loop + WORKING_COOKIE_BROWSER caching on success).