Fix OPC UA DT conversion from nanoseconds - #194
Open
genishernandez wants to merge 1 commit into
Open
Conversation
Author
|
The issue was detected while testing OPC UA DateTime ( During testing, the OPC UA We traced the issue to the value representation returned by the OpenPLC debug interface. In this case, the The conversion was updated to support integer nanosecond timestamps. The fix was verified using the current timestamp: Input: Result: The result matched the expected current UTC time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where OPC UA
DTvalues could be converted to1970-01-01instead of the actual DateTime.Problem
When the OPC UA synchronization layer receives a
DTvalue as aninteger Unix timestamp expressed in nanoseconds, the existing
conversion logic did not handle this representation.
As a result, the conversion fell back to:
1970-01-01 00:00:00+00:00Root Cause
The
DTconversion handled:(tv_sec, tv_nsec)tuplesdatetimeobjectsbut did not handle integer nanosecond timestamps returned by some
OpenPLC debug interfaces.
Fix
Added support for integer Unix timestamps expressed in nanoseconds: