fix(runtime): pin PHP 8.4 overlay with extension ABI exports - #2504
Merged
Conversation
Carry published @php-wasm/node-8-4 3.1.53 JSPI artifacts, which include the external-extension ABI exports from WordPress/wordpress-playground#4108. Keep the overlay package version at 3.1.46 so the 3.1.46 Playground driver dedupes onto it. Leave the PHP 8.3 mysqli_poll overlay and driver on 3.1.46 because playground#4170 is still unreleased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@php-wasm/node-8-43.1.53 (Playground8cd60ace8c3d32c8cb2b569b7471fdd98f88013e).convert_to_null,php_password_algo_find,php_password_algo_register,_emalloc_448, and the rest of the side-module PHP C ABI.@php-wasm/node3.1.46 dedupes onto it. Leave the Playground driver and the PHP 8.3mysqli_polloverlay on 3.1.46 because WordPress/wordpress-playground#4170 is still unreleased.Published 3.1.46 PHP 8.4 JSPI (
8_4_23, git581c7c17) does not export those symbols. 3.1.52 was published ~7h before #4108 merged. 3.1.53 JSPI (8_4_25) does export them. Asyncify 3.1.53 still does not; external extension manifests already require JSPI.This is a narrower alternative to #2476: overlay only PHP 8.4 from the now-published 3.1.53 artifacts, instead of bumping the whole Playground stack to 3.1.52.
Test plan
npm run test:php-wasm-external-extension-abinpm run checkAI assistance: GPT-6 Astra via OpenCode diagnosed the preceding blockers; Grok 4.6 via
opencode runroot-caused the extension ABI mismatch, implemented the fix, and ran the suites.