vip app deploy - Flag large archive files included in BYOR deploy#2889
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new preflight validation to vip app deploy to detect large nested archive files (e.g., .zip, .tar.gz, .tgz) inside the deployment archive and surface that to the user, with an opt-out flag.
Changes:
- Added archive scanning utilities in custom deploy validations to find nested archive files over 50 MB.
- Wired the new preflight check into
vip app deploy, with--skip-large-file-verifyto bypass. - Added Jest coverage for the new preflight validation flow and CLI wiring.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/validations/custom-deploy.ts | Adds helpers to detect nested deploy archives over a 50 MB threshold and refactors deploy extension detection. |
| src/lib/custom-deploy/custom-deploy.ts | Adds validateLargeArchiveFiles() that runs the scan, tracks events, and reports findings. |
| src/bin/vip-app-deploy.ts | Invokes the new validation during deploy preflight and introduces --skip-large-file-verify. |
| tests/lib/custom-deploy/custom-deploy.js | Adds unit tests for validateLargeArchiveFiles() behavior (success, flagged, and failure paths). |
| tests/bin/vip-app-deploy.js | Updates deploy command tests to assert the new validation runs (and is skippable). |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| .option( 'message', 'Add a description of a deployment.' ) | ||
| .option( 'skip-confirmation', 'Skip the confirmation prompt.' ) | ||
| .option( | ||
| 'skip-large-file-verify', |
Contributor
There was a problem hiding this comment.
Does --skip-large-files-validation sound better?
Contributor
Author
There was a problem hiding this comment.
Maybe --skip-large-file-validate
robersongomes
approved these changes
Jun 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Usually archive files shouldn't be included, so this is just a warning to the user in case.
Changelog Description
Changed
vip app deploythat warns when the deployment archive contains nested archive files over 50 MBPull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom