[RSM] Add AI title and summary fields to bookmark model and sync#5282
Open
sztomek wants to merge 2 commits into
Open
[RSM] Add AI title and summary fields to bookmark model and sync#5282sztomek wants to merge 2 commits into
sztomek wants to merge 2 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR lays groundwork for “smart bookmarks” by extending the bookmark model, protobuf sync payload, and Room schema to carry AI-generated title/summary metadata (plus modified timestamps) so it can be stored locally and propagated via sync.
Changes:
- Add
aiTitle/aiSummaryand corresponding*_modifiedfields to theBookmarkentity. - Extend
SyncUserBookmarkprotobuf and update bookmark incremental sync mapping to upload/download these fields. - Bump Room DB version to
128and add a127 → 128migration plus exported schema.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/services/repositories/src/main/java/au/com/shiftyjelly/pocketcasts/repositories/sync/data/BookmarkSync.kt | Upload/download AI fields for incremental bookmark sync payloads. |
| modules/services/protobuf/src/main/proto/sync_api.proto | Add ai_title / ai_summary and modified timestamps to SyncUserBookmark. |
| modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/entity/Bookmark.kt | Persist AI title/summary + modified timestamps on the bookmark entity. |
| modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/db/dao/BookmarkDao.kt | Introduce DAO update method for AI bookmark data. |
| modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/db/AppDatabase.kt | Bump Room version and add migration adding new bookmark columns. |
| modules/services/model/schemas/au.com.shiftyjelly.pocketcasts.models.db.AppDatabase/128.json | Export updated Room schema for version 128. |
MiSikora
approved these changes
May 8, 2026
Collaborator
|
Version |
geekygecko
approved these changes
May 24, 2026
sztomek
force-pushed
the
feat/smart-bookmarks-model
branch
from
59f12fc to
532e747
Compare
Collaborator
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR lays the groundwork for the smart bookmarks feature (phcsdm-1j8-p2)
It extends our existing models and database schemes so we could accomodate the changes later.
Testing Instructions
Just review the code pls.
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml