Reuse normalized conversion-report inputs - #1640
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reporting-maintainability slice under #242: reuse normalized inputs inside
ConversionReportProjection::fromResultParts().No new class, cache, persistent state, option or public signature. Report keys, ordering, omissions, classifications and deduplication behavior remain unchanged. No unmeasured speed claim.
Verification
Baseline:
a57b5f2dd09eaa4a9d81d622a9b4672677516c56.Candidate:
2d345985af6126ccd4d7a47edf84b3932511a247.All ten final CI checks passed: PHP 8.2-8.5 package and WordPress integration suites, plus generic visual parity tools, and solved-site promotion.
520a6c71343bab56933991a5cd51cc85483207c03f0204d37998b8e35f1bc6f4.Reproduce
From
php-transformer, with dependencies and child PHP memory configured:composer test php tests/unit/conversion-report-projection-input-reuse.php php -d memory_limit=512M tools/benchmarks/validation-evidence-compare.php ../fixtures REQUIRE_WP_TESTS=1 WP_TESTS_DIR=/path/to/wordpress-tests composer test:wordpress-integrationThe corpus comparison command from #1627 applies unchanged to the baseline/candidate revisions above with matching dependencies.
AI Assistance
OpenAI GPT-5.6 Terra via direct OpenCode implemented the local reuse and behavioral test, then ran lab gates. GPT-6 Astra via OpenCode coordinated and reviewed ordering/count/deduplication semantics, independently reran the final corpus/artifact comparison and prepared this PR under Chris Huber's direction. No release or deployment was performed.