Repository navigation
doctor: check running servers have -allow_round_backup_files - #138
Merged
Merged
Conversation
…iles CS2 writes round backups only when launched with the flag. csm adds it since v1.27.4, but a server started earlier keeps running without it and a round restore then finds no backup. doctor now reads each running server's cs2 /proc/<pid>/cmdline and, if the flag is missing, says to restart that server (csm restart server-N). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
csm doctorgets a check: for every running server it finds the cs2 process (cwd underserver-N, argv0cs2), reads/proc/<pid>/cmdlineand requires-allow_round_backup_files. If missing it fails and says to restart that server (csm restart server-N).Why
CS2 writes round backups only with that flag. csm adds it since v1.27.4 (#137), but servers started earlier keep running without it, so round restore finds no backup. The flag only applies at launch, so a restart is the fix (the check does not restart anything).
Tests
Unit tests against a fake /proc (server-1 vs server-10 prefix, launcher vs cs2 process, exact-arg match, none running, session up but no process). Ran in golang:1.23 on Linux.
🤖 Generated with Claude Code