feat: add eDNA Explorer platform - #284
Merged
Merged
Conversation
- Add EDNA_EXPLORER to PlatformEnum + admin PLATFORM_MAPPING - Alembic migration adding the EDNA_EXPLORER enum value - Keep it out of DEFAULT_PLATFORMS so access is manual-approval only - Tests: admin create + no auto-grant on registration Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amandazhuyilan
force-pushed
the
AAI-860-add-edna-explorer
branch
from
July 17, 2026 00:40
3579bec to
b78e970
Compare
…orer # Conflicts: # tests/admin_api/test_admin.py # tests/test_biocommons_register.py
5 tasks
amandazhuyilan
requested review from
marius-mather and
minh-biocommons
and removed request for
marius-mather
July 28, 2026 01:34
marius-mather
requested changes
Jul 28, 2026
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks OK but the migration is blank - do we need it?
amandazhuyilan
force-pushed
the
AAI-860-add-edna-explorer
branch
from
July 28, 2026 04:04
fb5f988 to
686003f
Compare
alembic-postgresql-enum recreates the enum type, which fails on PlatformEnum: platform.id is a PK referenced by FKs in platformrolelink/platformmembership/ platformmembershiphistory, so recreation errors with 'foreign key constraint cannot be implemented' (broke check-migrations on Postgres). Revert the plugin (dep + env.py wiring + lockfile churn) and add EDNA_EXPLORER in place via ALTER TYPE ... ADD VALUE, matching SBP (575a146957f2) and REJECTED (c4c7a8e9b2d3). Verified upgrade/check/downgrade on Postgres + SQLite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amandazhuyilan
force-pushed
the
AAI-860-add-edna-explorer
branch
from
July 28, 2026 06:25
a6f9f6f to
d0d601e
Compare
marius-mather
self-requested a review
July 28, 2026 06:27
marius-mather
approved these changes
Jul 28, 2026
marius-mather
left a comment
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
looking good now, thanks for fixing the migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AAI-860: Adds eDNA Explorer as a platform. Unlike bpa/galaxy/sbp, access is manual-approval only (not auto-granted at registration).
Changes
EDNA_EXPLORERtoPlatformEnumPLATFORM_MAPPINGEDNA_EXPLORERenum value (row created by the existingpopulate_platforms_from_auth0sync)DEFAULT_PLATFORMS→ new users land inPENDINGuntil an admin approvesRelated infra code changes here: https://github.com/AustralianBioCommons/aai-infrastructure/pull/32
Checklist
How to Test Manually (if necessary)
CI tests shall pass!