Repository navigation
feat(skills): ship the engine inside the executor skill - #15
Merged
Merged
Conversation
An installed skill is a copied directory, so the engine at engine/ — a sibling of skills/ — never reached users and the bare 'executor' command the skills name did not exist. The router skill now carries a generated mirror of the engine at scripts/lib/executor/ plus a launcher that resolves it relative to itself, so installation needs no pip, no PYTHONPATH, and no PATH edit. engine/executor/ remains the source the suite imports; scripts/sync_engine.py is the only writer of the bundle and --check is a CI gate, with a drift test in the suite. CI also copies the skill out of the tree, drops PYTHONPATH, and runs the launcher from an unrelated directory. Docs: README install path rewritten around the launcher, CONTRIBUTING describes the Python entry points and bundle rule, every skill states the invocation spelling, and source citations point inside the skill. Bumps the engine to 2.0.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a user
Before:
npx skills addcopied the skill directories, but the engine lived atengine/— a sibling ofskills/— so it never reached an installed user. The skills callexecutor <verb>, and noexecutorexisted without a clone and an exportedPYTHONPATH.After: the router skill carries the engine at
skills/executor/scripts/lib/executor/, with a launcher beside it atskills/executor/scripts/executor. The launcher resolves its engine from__file__, so installation needs nopip, noPYTHONPATH, and noPATHedit. Python 3.11+ is the only requirement.How the two copies stay honest
engine/executor/remains the source of truth and what the suite imports.scripts/sync_engine.pyis its only writer.python3 scripts/sync_engine.py --checkis a CI gate andengine/tests/test_engine_ships_with_skill.pyfails on drift.PYTHONPATH, and runs the launcher from an unrelated directory.Docs
README install path rewritten around the launcher; CONTRIBUTING now describes the Python entry points, the 100% branch floor, and the bundle rule; every phase skill states the invocation spelling; source citations point inside the skill. Version is 2.0.2 with a CHANGELOG entry.
Verification
python3 scripts/run_tests.py— 739 tests, 100% branch coveragepython3 scripts/sync_engine.py --check— in syncpython3 scripts/validate_skills.py— cleanpython3 scripts/lint-prompt-injection.py skills/— cleannpx skills addinstall from an unrelated repo withPYTHONPATHunset:--version,new, andstatusall ran