Skip to content

feat(skills): ship the engine inside the executor skill - #15

Merged
Atri10 merged 1 commit into
mainfrom
feature/ship-engine-with-skills
Oct 19, 2026
Merged

Atri10 merged 1 commit into
mainfrom
feature/ship-engine-with-skills

Conversation

@Atri10

@Atri10 Atri10 commented Oct 19, 2026

Copy link
Copy Markdown
Owner

What changes for a user

Before: npx skills add copied the skill directories, but the engine lived at engine/ — a sibling of skills/ — so it never reached an installed user. The skills call executor <verb>, and no executor existed without a clone and an exported PYTHONPATH.

After: the router skill carries the engine at skills/executor/scripts/lib/executor/, with a launcher beside it at skills/executor/scripts/executor. The launcher resolves its engine from __file__, so installation needs no pip, no PYTHONPATH, and no PATH edit. Python 3.11+ is the only requirement.

How the two copies stay honest

  • engine/executor/ remains the source of truth and what the suite imports.
  • The bundle is generated; scripts/sync_engine.py is its only writer.
  • python3 scripts/sync_engine.py --check is a CI gate and engine/tests/test_engine_ships_with_skill.py fails on drift.
  • CI also copies the skill out of the tree, drops PYTHONPATH, and runs the launcher from an unrelated directory.

Docs

README install path rewritten around the launcher; CONTRIBUTING now describes the Python entry points, the 100% branch floor, and the bundle rule; every phase skill states the invocation spelling; source citations point inside the skill. Version is 2.0.2 with a CHANGELOG entry.

Verification

  • python3 scripts/run_tests.py — 739 tests, 100% branch coverage
  • python3 scripts/sync_engine.py --check — in sync
  • python3 scripts/validate_skills.py — clean
  • python3 scripts/lint-prompt-injection.py skills/ — clean
  • Real npx skills add install from an unrelated repo with PYTHONPATH unset: --version, new, and status all ran

An installed skill is a copied directory, so the engine at engine/ — a
sibling of skills/ — never reached users and the bare 'executor' command
the skills name did not exist. The router skill now carries a generated
mirror of the engine at scripts/lib/executor/ plus a launcher that
resolves it relative to itself, so installation needs no pip, no
PYTHONPATH, and no PATH edit.

engine/executor/ remains the source the suite imports;
scripts/sync_engine.py is the only writer of the bundle and --check is a
CI gate, with a drift test in the suite. CI also copies the skill out of
the tree, drops PYTHONPATH, and runs the launcher from an unrelated
directory.

Docs: README install path rewritten around the launcher, CONTRIBUTING
describes the Python entry points and bundle rule, every skill states the
invocation spelling, and source citations point inside the skill.

Bumps the engine to 2.0.2.
@Atri10
Atri10 merged commit 64bf2fe into main Oct 19, 2026
4 of 5 checks passed
@Atri10
Atri10 deleted the feature/ship-engine-with-skills branch October 19, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant