fix(http): apply SSRF guard to os.http.request - #46
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Os.web.fetch already blocked private/internal addresses and pinned DNS; os.http.request did not, so model-controlled curl could hit metadata/LAN while web.fetch of the same URL failed. Share the guard, pin --resolve, and re-validate each redirect hop. Closes AtomicBot-ai#45 Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.web.fetch blocked private/internal hosts; os.http.request did not, so model-controlled curl could reach metadata/LAN under the default-open allowlist. Apply the same SSRF guard, pin curl with --resolve, and re-check each redirect hop.
Closes #45
Tested:
npx vitest run src/tools/os/http-request.test.ts src/tools/os/web-fetch-ssrf-guard.test.ts→ 42 passedAgent-Owner: sera
Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h