Skip to content

Fix projectile facing direction at launch #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FluxCapacitor2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix projectile facing direction at launch #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/ca/atlasengine/projectiles/AbstractProjectile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ protected final void launch(Point from, Point to, double power, double uncertain
}

Vec velocity = movement.mul(ServerFlag.SERVER_TICKS_PER_SECOND);
Pos spawnPosition = new Pos(from.x(), from.y(), from.z()).withDirection(movement);
Pos spawnPosition = withProjectileView(movement, from);
setInstance(instance, spawnPosition).whenComplete((ignored, throwable) -> {
if (throwable != null) {
remove();
Expand Down Expand Up @@ -232,9 +232,13 @@ public final boolean isInBlock() {

private void updateProjectileRotation(Vec movement) {
if (movement.isZero()) return;
position = withProjectileView(movement, position);
}

private static Pos withProjectileView(Vec movement, Point position) {
float yaw = (float) Math.toDegrees(Math.atan2(movement.x(), movement.z()));
float pitch = (float) Math.toDegrees(Math.atan2(movement.y(), Math.hypot(movement.x(), movement.z())));
position = position.withView(yaw, pitch);
return new Pos(position.x(), position.y(), position.z(), yaw, pitch);
}

private void callBlockCollision() {
Expand Down