Skip to content

fix: ASSOC crash, ARM64 WOW64 detect, LibreWolf downloads, Core Isolation warning - #1724

Merged
RadNotRed merged 3 commits into
Atlas-OS:new-updatefrom
Longno242:fix/assoc-arm-core-isolation-warnings
Oct 17, 2026
Merged

RadNotRed merged 3 commits into
Atlas-OS:new-updatefrom
Longno242:fix/assoc-arm-core-isolation-warnings

Conversation

@Longno242

@Longno242 Longno242 commented Sep 9, 2026 •

Copy link
Copy Markdown

Fixes a few small issues:

…solation

Prevent ASSOC.ps1 from crashing when Shell32 lacks the English user-experience string, check LibreWolf curl downloads, detect ARM64 under WOW64, and warn that disabling Core Isolation can break WSL2/Docker.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added playbook Playbook related issues/PRs tweaks Modifications to the 'tweaks' in the Playbook labels Sep 9, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@jacksyrm
jacksyrm self-requested a review September 23, 2026 17:29

@jacksyrm jacksyrm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARM64 changes look good. A couple of things with the rest:

For ASSOC, skipping the substring avoids the error, but leaves $userExperience empty. We then carry on replacing the associations with a hash that's missing part of its input. Could we stop before touching the registry if we can't find the string? The closing } needs checking too. This applies to both copies of the script.

The curl checks also need --fail on both commands, otherwise a 404 can still return exit code 0.

I'd leave out the WSL2/Docker warning for now. This option disables VBS features, but doesn't turn off the hypervisor or Virtual Machine Platform. I don't think #1615 gives us enough to say this checkbox breaks them.

Stop ASSOC before touching the registry when the Shell32 user experience string or its closing brace can't be found, add --fail to both LibreWolf curl downloads, and drop the WSL2/Docker Core Isolation warning.
@Longno242

Copy link
Copy Markdown
Author

Thanks for the review. Changes are in d6ff647:

  • ASSOC (both copies): if the user experience string or its closing } can't be found in Shell32.dll, the script now prints a message and exits before touching the registry, instead of continuing with an empty value.
  • LibreWolf: added --fail to both curl downloads, so an HTTP error like a 404 now gives a non-zero exit code.
  • Core Isolation: removed the WSL2/Docker warning from playbook.conf and script-core-isolation.yml.

The ARM64 changes are unchanged.

@github-actions github-actions Bot removed the tweaks Modifications to the 'tweaks' in the Playbook label Oct 11, 2026
@RadNotRed
RadNotRed merged commit b4220a7 into Atlas-OS:new-update Oct 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playbook Playbook related issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants