Repository navigation
fix: ASSOC crash, ARM64 WOW64 detect, LibreWolf downloads, Core Isolation warning - #1724
Conversation
…solation Prevent ASSOC.ps1 from crashing when Shell32 lacks the English user-experience string, check LibreWolf curl downloads, detect ARM64 under WOW64, and warn that disabling Core Isolation can break WSL2/Docker. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
jacksyrm
left a comment
There was a problem hiding this comment.
The ARM64 changes look good. A couple of things with the rest:
For ASSOC, skipping the substring avoids the error, but leaves $userExperience empty. We then carry on replacing the associations with a hash that's missing part of its input. Could we stop before touching the registry if we can't find the string? The closing } needs checking too. This applies to both copies of the script.
The curl checks also need --fail on both commands, otherwise a 404 can still return exit code 0.
I'd leave out the WSL2/Docker warning for now. This option disables VBS features, but doesn't turn off the hypervisor or Virtual Machine Platform. I don't think #1615 gives us enough to say this checkbox breaks them.
Stop ASSOC before touching the registry when the Shell32 user experience string or its closing brace can't be found, add --fail to both LibreWolf curl downloads, and drop the WSL2/Docker Core Isolation warning.
|
Thanks for the review. Changes are in d6ff647:
The ARM64 changes are unchanged. |
Fixes a few small issues: