fix(MultiMarketPower): guard OnCalculate forward-fill against bar 0 - #181
Open
AlbertoAmadorBelchistim wants to merge 1 commit into
Open
AlbertoAmadorBelchistim wants to merge 1 commit into
AlbertoAmadorBelchistim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #173 as requested in the review.
OnCalculateforward-fills empty values of the forming bar from the previous bar:When the forming bar is bar 0 (a chart with a single bar, e.g. right after the history response on a new instrument or a very short range),
bar - 1is-1and the indexer is called with a negative index. The fix returns early for bar 0, where there is no previous value to carry forward:No behavior change for any other bar. Single-line change, rebased on the current Develop.