Skip to content

fix(ClusterSearch): Remove dead members in ClusterSearch - #172

Open
AlbertoAmadorBelchistim wants to merge 1 commit into
AtasPlatform:Developfrom
AlbertoAmadorBelchistim:fix/ClusterSearch-dead-fields
Open

AlbertoAmadorBelchistim wants to merge 1 commit into
AtasPlatform:Developfrom
AlbertoAmadorBelchistim:fix/ClusterSearch-dead-fields

Conversation

@AlbertoAmadorBelchistim

Copy link
Copy Markdown
Contributor

What

Removes unused members from ClusterSearch:

  • _pocPrice and _pocVolume private fields — assigned in CalculateBarFull
    (the MaxVolume/POC branch) but never read anywhere. The POC level itself is
    still handled through pocInfo / PlaceToDataSeries; these two fields were
    redundant copies.
  • Transparency public property ([Browsable(false)]) — shadowed by
    VisualObjectsTransparency, which is the property actually wired to the visual
    objects. Transparency had no readers.

Why

Dead code: write-only fields and an unreferenced property. Removing them reduces
noise and avoids confusion with the live VisualObjectsTransparency.

Behavior

No functional change. POC handling and transparency are unaffected. Builds on all
targeted flavors.

@Stig4all

Copy link
Copy Markdown
Collaborator

Thanks for the cleanup. Removing the unused private fields looks fine, but we cannot merge this PR as-is.
The risky part is removing the hidden public Transparency property. Even though it does not appear to be used in the current code path, it may still be part of backward compatibility for saved templates or workspaces. Deleting hidden public settings is usually risky unless we are certain they are no longer serialized or consumed anywhere.
If the goal is cleanup, I would keep the compatibility property and map it to VisualObjectsTransparency instead of removing it entirely.
So for now we cannot accept this change in its current form.

@AlbertoAmadorBelchistim

Copy link
Copy Markdown
Contributor Author

Good point on template compatibility. Pushed a follow-up commit that restores Transparency with its original attributes as a hidden compatibility alias mapped to VisualObjectsTransparency - legacy serialized values are now applied to the live setting instead of being dropped, and the property stays out of the UI via [Browsable(false)]. The dead-field cleanup is unchanged.

@Stig4all

Stig4all commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

The unused private-field cleanup looks fine. Before merging the compatibility-property change, we need to verify loading existing templates and workspaces.
Previously, Transparency was an independent property; now its setter changes VisualObjectsTransparency. If an existing template contains both properties with different values, loading the hidden property could overwrite the intended visible setting, depending on deserialization order.
Please validate that scenario. Alternatively, keep Transparency unchanged and limit this PR to removing the unused private fields.

The fields were written in CalculateBarFull but never read.
The Transparency property is left unchanged so that existing templates
and workspaces keep loading exactly as before.
@AlbertoAmadorBelchistim

Copy link
Copy Markdown
Contributor Author

Thanks. I have reduced the PR to the unused-field cleanup: _pocPrice and _pocVolume are removed, and Transparency is left exactly as it is in Develop, so template and workspace loading is unaffected. The branch is rebased on the current Develop as a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants