fix: fix: restore missing WebChat sessions - #9607
Open
Alchuang22-dev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
test_chat_stream_creates_missing_webchat_platform_session, the teardown useschat_service.webchat_queue_mgr.remove_queues(session_id)instead ofservice.webchat_queue_mgr.remove_queues(session_id), which will raise a NameError and should be corrected. - The new WebChat session backfill in
build_chat_streamrelies on the literal stringplatform_history_id == "webchat"; consider centralizing this identifier (or aligning with the platform id constants already used elsewhere) to avoid subtle mismatches and make future changes easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `test_chat_stream_creates_missing_webchat_platform_session`, the teardown uses `chat_service.webchat_queue_mgr.remove_queues(session_id)` instead of `service.webchat_queue_mgr.remove_queues(session_id)`, which will raise a NameError and should be corrected.
- The new WebChat session backfill in `build_chat_stream` relies on the literal string `platform_history_id == "webchat"`; consider centralizing this identifier (or aligning with the platform id constants already used elsewhere) to avoid subtle mismatches and make future changes easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9605 issue
Modifications / 改动点
修复了后端消息入口直接写入
platform_message_history,没有查询或补建platform_sessions导致的 sidebar 相关问题。对应代码在chat_service.py (line 1090)Fix WebChat conversations that have message history but are missing from the sidebar because no corresponding
platform_sessionsrecord exists.Ensure a WebChat platform session exists when processing a message.
Make the existing WebChat session migration run idempotently on every startup.
Preserve normal message delivery if session backfilling fails.
Add a focused regression test based on the existing ChatService test fixture.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
在
test_chat_route.py中添加了相关的新测试。Commands:
ruff format .ruff check .pytest tests/test_chat_route.py -q— 10 passedChecklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
PTAL!
Summary by Sourcery
Ensure WebChat conversations are correctly surfaced by creating missing platform sessions at message processing time and making the WebChat session migration rerunnable.
Bug Fixes:
Enhancements:
Tests: