Skip to content

[CI] Update Mooncake version in CI - #161

Merged
0oshowero0 merged 2 commits into
Ascend:mainfrom
0oshowero0:mooncake_ver
Aug 31, 2026
Merged

[CI] Update Mooncake version in CI#161
0oshowero0 merged 2 commits into
Ascend:mainfrom
0oshowero0:mooncake_ver

Conversation

@0oshowero0

Copy link
Copy Markdown
Collaborator

As title

Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
Copilot AI lite review requested due to automatic review settings August 31, 2026 12:45
@ascend-robot

Copy link
Copy Markdown

CLA Signature Pass

0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T12:48:46.715103Z 142012c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI dependency installation for the Mooncake transfer engine by removing a previously applied version constraint in the main test workflow.

Changes:

  • Removed the <0.3.12 pin for mooncake-transfer-engine-non-cuda in the test workflow.
  • Removed inline comments explaining why the pin existed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 35 to +36
pip install -e ".[test,build,yuanrong]"
# Pin below 0.3.12: the 0.3.12 non-cuda wheel ships a mooncake_master binary
# linked against libcudart.so.12, which fails to start on runners without CUDA.
pip install "mooncake-transfer-engine-non-cuda<0.3.12"
pip install "mooncake-transfer-engine-non-cuda"
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
@ascend-robot

Copy link
Copy Markdown

CLA Signature Pass

0oshowero0, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@0oshowero0
0oshowero0 merged commit 06ad9c9 into Ascend:main Aug 31, 2026
7 checks passed
@0oshowero0
0oshowero0 deleted the mooncake_ver branch August 31, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants