Repository navigation
Conversation
Users on Android TV and Google TV devices could not launch or navigate the app with a directional pad or remote control. Add Leanback launcher banners, landscape locks on TV, visual D-Pad focus indicators across playback and preferences, and remote key handling for seekbar and sheet navigation. Unmeasured.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying mpvium with
|
| Latest commit: |
440ed7d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5de0e7fd.mpvium.pages.dev |
| Branch Preview URL: | https://android-tv-support.mpvium.pages.dev |
Reviewer's GuideData structuresAdd TV-device detection and a composition local so downstream UI and playback behavior can distinguish television devices.
APIDeclare optional Leanback and device features, launcher categories, and TV banners, and register the Leanback banner resource.
ImplementationHandle TV playback orientation, Back behavior, and remote media and D-Pad key events, while refreshing the controls timeout on remote interaction.
UIAdd shared focus highlighting and apply it to browsing and streaming cards, player controls, and preference navigation tiles.
Make Modern player transport, action buttons, and seekbar focusable with visible focus state, initial play/pause focus, and D-Pad seek steps.
Add focus borders and focus targeting for track, chapter, playlist, and subtitle sheet controls, and constrain preference cards and choice sheets for wide displays.
Other changesFiles not grouped.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e98d42260
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val areControlsVisible = viewModel.controlsShown.value | ||
|
|
||
| if (areControlsVisible) { | ||
| viewModel.keepControlsAlive() |
There was a problem hiding this comment.
Keep controls alive during D-pad focus navigation
On Android TV, when playback is running and the user moves between Compose focus targets without activating one, Compose consumes those D-pad events before they reach Activity.onKeyDown. This leaves the key-interaction timer unchanged, so the 5-second auto-hide can dismiss the controls mid-navigation and drop focus. Refresh the timer from Compose focus/key handling too, or suppress the timeout while a control is focused.
AGENTS.md reference: AGENTS.md:L125-L128
Useful? React with 👍 / 👎.
Landscape media stored in Downloads was excluded from Titles on Android TV because mobile transient clip thresholds hid files under 20 minutes. Exempt Android TV environments from the 20-minute download threshold in MovieLibraryClassifier so sideloaded and downloaded media appears in Titles. Unmeasured.
Summary
Adds comprehensive Android TV and Google TV platform support, including Leanback launcher declaration, banner resources, orientation constraints, visual D-Pad focus indicators across player controls, sheets, and preferences, and key event handling for remote-driven playback control.
Before / After
How measured
Unmeasured (architectural and UI adaptation).
Verification
bash ./gradlew assembleStandardDebugcompleted with code 0 (BUILD SUCCESSFUL in 37s/1m 3s).bash ./gradlew testStandardDebugUnitTestcompleted with code 0 (BUILD SUCCESSFUL in 1m 42s).git diff --checkclean with 0 warnings..opencode/skills/commit-messages/scripts/check-commit-msg.shpassed.Changelog
Risks
Low. Non-TV touch workflows preserve identical touch ripples and gesture interactions; TV-specific orientation locks and auto-focus logic only trigger when
DeviceUtils.isTv()evaluates to true or D-Pad navigation events are detected.Summary by Sourcery
Add comprehensive Android TV and Google TV support with remote navigation, TV-optimized layouts, and accessible focus feedback throughout the app.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores: