fix(telemetry): bump semconv to v1.39 to match OTel SDK 1.40 schema URL#898
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
285861a to
4958615
Compare
winton-library
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes a runtime panic introduced when PR #894's OTel SDK bump (v1.38 → v1.40) made
resource.Default()use schema URLv1.39.0whilepkg/telemetry/setup.gostill importedsemconv/v1.37.0.resource.Mergeerrors on conflicting schema URLs, so every cardinal shard panics on boot:Caught locally while testing the rampage-backend bump in Argus-Labs/rampage-backend#612 — every gameplay shard panicked at startup with the trace above.
Change
One-line import bump:
semconv/v1.37.0→semconv/v1.39.0. v1.39 is what OTel SDK 1.40'sresource.Default()reports as its schema URL, so the merge succeeds.The semconv subpackage ships inside
go.opentelemetry.io/otelitself (already at v1.40.0 in go.mod), so no dependency churn.Test plan