docs: add v3.2.0 smoke test plan#82
Conversation
Concrete walkthrough for the Intel-Aware Edition. Every test has an explicit "do X, expect Y" so a missing or broken behavior is unambiguous — no detective work, file an issue and move on. Covers all 10 features from the v3.2.0 chain plus cross-cutting tests for decay timing and chrome stacking interactions. ~30 min for the happy path. Includes a "Manual report injection" recipe for triggering DANGER / CRITICAL alerts (the in-app Test Alert button only fires WARNING) and for forcing per-character system state without waiting for log parsing. Sets up follow-up issue triage with a copy-paste template. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive smoke test plan for version 3.2.0, covering features like per-character tracking, threat chrome, and replay strips. Feedback highlights several critical inconsistencies between the test plan and the actual implementation, including mismatched UI labels, missing settings controls, and a configuration key mismatch that would break jump-distance filtering. Additionally, improvements were suggested regarding platform-agnostic log paths and corrected file references.
| 2. **Settings → Intel** — verify all four controls render: | ||
| - "Show threat chrome on previews" (master toggle, on) | ||
| - "Track per-character location" (on) | ||
| - "Max jumps for tinting" (default 1, range 0-5) | ||
| - Replay strip count summary |
There was a problem hiding this comment.
Several UI elements and settings mentioned in this setup checklist are inconsistent with the current implementation in src/argus_overview/ui/intel_tab.py:
- Label Mismatches: The UI labels in
IntelTabare "Alert within (jumps)" and "Cooldown (seconds)", whereas the test plan uses different names. - Missing Controls: "Show threat chrome on previews" and "Track per-character location" are not present in the
IntelTabsettings panel. While the latter exists as a setting inMainWindowV21, it lacks a UI toggle in the provided code. - Range/Default Discrepancy: Line 23 specifies a range of 0-5 and a default of 1 for jumps, but the code in
IntelTab(lines 212, 427) uses a default of 5 and a range of 0-50. - Replay Summary: The "Replay strip count summary" is not implemented in the UI.
| 7. Move character B 3+ jumps away. | ||
| 8. Fire same alert. | ||
| 9. **Expect**: character B's frame is **untinted** (default | ||
| `intel.threat_jumps_threshold = 1` excludes it). |
There was a problem hiding this comment.
There is a significant configuration key mismatch between the UI and the core logic. IntelTab (line 261) saves the jump setting to intel.jumps_threshold, but MainWindowV21 (line 190) reads from intel.threat_jumps_threshold. This will cause Test 5 to fail because UI changes won't propagate to the jump filtering logic. Additionally, the default values are inconsistent (1 in logic vs 5 in UI).
| 7. **Expect**: each character tracks independently. | ||
|
|
||
| **If broken**: most likely the EVE log path detection failed. Check | ||
| `~/.eve/logs/Chatlogs/` for `Local_*.txt` files dated today. If those |
There was a problem hiding this comment.
The path ~/.eve/logs/Chatlogs/ is specific to Linux/Proton environments. To support Windows users (who typically find logs in Documents\EVE\logs\Chatlogs), please update the instructions to be platform-agnostic or include both paths.
|
|
||
| 1. Move character A to system X, character B to system Y. Wait for | ||
| chip labels to update. | ||
| 2. Edit `intel/parser.py` test injection or use the Python console (see |
There was a problem hiding this comment.
The file path intel/parser.py should be src/argus_overview/intel/parser.py to match the project structure.
|
|
||
| - Test Alert button only fires WARNING; use the manual injection | ||
| recipe for DANGER/CRITICAL. | ||
| - The `replay_strip_enabled` summary in IntelPanel is read-only — |
There was a problem hiding this comment.
The reference to IntelPanel appears to be a typo for IntelTab. Also, as noted in the setup section, this summary is currently missing from the UI implementation.
1 participant
Summary
Concrete walkthrough for the Intel-Aware Edition with explicit "do X, expect Y" steps so missing or broken behavior is unambiguous. Targets ~30 min for the happy path through all 10 features.
What's covered
Why
Everything was tested in offscreen Qt. This doc bridges the gap between unit-tested correctness and real-EVE-running correctness. Things tests can't catch:
Follow-up
After running this, file issues against `smoke-test-v3.2.0` label for anything that doesn't behave as documented.
🤖 Generated with Claude Code