Repository navigation
Conversation
0.13.5 parses nested image wikilinks in quadratic time, and stet turns on ENABLE_WIKILINKS, so a crafted document could stall the editor when opened. 0.13.6 is a one-line fix on the 0.13 branch; nothing else in the lockfile moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cargo auditfails onmainwithRUSTSEC-2026-0433
(high, 7.5): pulldown-cmark 0.13.5 parses nested image wikilinks in quadratic
time. Stet enables
Options::ENABLE_WIKILINKS(
crates/stet-core/src/markdown.rs:256), so a crafted document could stallthe editor when opened.
This updates pulldown-cmark to 0.13.6 with
cargo update -p pulldown-cmark --precise 0.13.6. Only that entry inCargo.lockchanges; no other crate moves and no dependency is added.Dependabot's #13 includes the same bump, but it's grouped with 20 other
updates (including
objc20.6 andjupyter-zmq-client3) and CI fails there.This lands the security fix on its own; Dependabot will drop it from the group
when it rebases.
Review of the release
0.13.3 through 0.13.5; the crate's owners are unchanged.
branch_0.13, two commits afterv0.13.5: the fix(3288371)
and the version bump, tagged
v0.13.6.self.wikilink_stack.clear();, plus acomment and a new test that reproduces the advisory's input.
build.rsandthe dependency list are unchanged from 0.13.5.
.cratematches the checksum inCargo.lock, and itssrc/parse.rs,build.rsand wikilink tests match the GitHub source at thetagged commit byte for byte.
Verification
cargo fmt --check,cargo clippy --all-targets --all-features -D warnings,cargo docwith-D warnings, andcargo test --all-targets --all-features(307 passed, 2 ignored, as on
main) all pass locally.STET_FUZZ=20000 cargo test --release -p stet-core incremental_analysispasses.
cargo auditpasses; the six allowed warnings are unchanged.Checklist
🤖 Generated with Claude Code